RFR: 8339535: JVM crashes with -Xshare:dump -XX:+SegmentedCodeCache

[Ioi Lam]

`CDSConfig::check_vm_args_consistency()` should be called before `CompilerConfig::check_args_consistency(status)`

I also made `patch_mod_javabase` into a global, so that it doesn't need to be passed around.

-------------

Commit messages:
 - 8339535: java -Xshare:dump -XX:+SegmentedCodeCache crashes

Changes: https://git.openjdk.org/jdk/pull/22527/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22527&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339535
  Stats: 29 lines in 3 files changed: 7 ins; 5 del; 17 mod
  Patch: https://git.openjdk.org/jdk/pull/22527.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22527/head:pull/22527

PR: https://git.openjdk.org/jdk/pull/22527