RFR: 8339535: JVM crashes with -Xshare:dump -XX:+SegmentedCodeCache

[Vladimir Kozlov]

On Tue, 3 Dec 2024 20:14:29 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> `CDSConfig::check_vm_args_consistency()` should be called before `CompilerConfig::check_args_consistency(status)`
> 
> I also made `patch_mod_javabase` into a global, so that it doesn't need to be passed around.

src/hotspot/share/runtime/arguments.cpp line 1783:

> 1781:   if (!CDSConfig::check_vm_args_consistency(patch_mod_javabase, mode_flag_cmd_line)) {
> 1782:     return false;
> 1783:   }

`check_vm_args_consistency` is only directly referenced in this file now. Can it be declared as local `static`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22527#discussion_r1868443520