RFR: 8339535: JVM crashes with -Xshare:dump -XX:+SegmentedCodeCache

[Vladimir Kozlov]

On Tue, 3 Dec 2024 23:14:38 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> src/hotspot/share/runtime/arguments.cpp line 1783:
>> 
>>> 1781:   if (!CDSConfig::check_vm_args_consistency(patch_mod_javabase, mode_flag_cmd_line)) {
>>> 1782:     return false;
>>> 1783:   }
>> 
>> `check_vm_args_consistency` is only directly referenced in this file now. Can it be declared as local `static`?
>
> `Arguments::check_vm_args_consistency()` is also called from jvmFlag.cpp so we can't make it local to arguments.cpp.

Sorry, I copy/past wrong name. I meant `patch_mod_javabase` variable. It can be local static I think.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22527#discussion_r1868504050