RFR: 8339535: JVM crashes with -Xshare:dump -XX:+SegmentedCodeCache [v2]

[Ioi Lam]

> `CDSConfig::check_vm_args_consistency()` should be called before `CompilerConfig::check_args_consistency(status)`
> 
> I also made `patch_mod_javabase` into a global, so that it doesn't need to be passed around.

Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:

  @vnkozlov and @calvinccheung comments - made variables static/local; updated copyright year

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22527/files
  - new: https://git.openjdk.org/jdk/pull/22527/files/3059c03b..0860ffef

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22527&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22527&range=00-01

  Stats: 7 lines in 2 files changed: 0 ins; 0 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/22527.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22527/head:pull/22527

PR: https://git.openjdk.org/jdk/pull/22527