RFR: 8345503: Test EnableNativeAccessCDS.java fails with TEST_THREAD_FACTORY=Virtual

Leonid Mesnik lmesnik at openjdk.org
Wed Dec 4 19:10:19 UTC 2024


On Wed, 4 Dec 2024 18:43:35 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> The JTREG option `TEST_THREAD_FACTORY=Virtual` injects command line arguments into the test and may separate an option from its arguments. In this case, the option was being placed between `--enable-native-access` and it's argument `java.base`. This patch joins the option and argument together to avoid the issue.

You need to add this option to list here:https://github.com/openjdk/jdk/blob/master/test/lib/jdk/test/lib/process/ProcessTools.java#L394

So ProcessTools knows that next toke is the 2nd parameter of the option.

Also, the  TEST_THREAD_FACTORY=Virtual
is useless when java doesn't run any classes.  I expect it should silently pass.

So test might be excluded.

-------------

Changes requested by lmesnik (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22555#pullrequestreview-2479671121
PR Comment: https://git.openjdk.org/jdk/pull/22555#issuecomment-2518335956


More information about the hotspot-runtime-dev mailing list