RFR: 8345514: Should use internal class name when calling ClassLoader.getResourceAsByteArray

Wed Dec 4 20:40:39 UTC 2024

On Wed, 4 Dec 2024 06:05:45 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> This patch is for fixing an assert failure in [filemap.cpp](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/cds/filemap.cpp#L2714). It was introduced via JDK-8343427.
> The bug is that an external class name (e.g. pkg1.Foo) was passed as the argument when calling the java method `ClassLoader.getResourceAsByteArray()` which expects an internal class name (e.g. pkg1/Foo).
> The test case for JDK-8343427 has been updated to include package names in test classes.
> 
> Passed tiers 1 - 5 testing.

LGTM!

-------------

Marked as reviewed by matsaave (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22535#pullrequestreview-2479854094