RFR: 8205051: UseNUMA memory interleaving vs cpunodebind & localalloc [v2]

Stefan Johansson sjohanss at openjdk.org
Thu Dec 5 08:35:40 UTC 2024


On Tue, 3 Dec 2024 21:16:41 GMT, Sangheon Kim <sangheki at openjdk.org> wrote:

>> Swati Sharma has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8205051: Resolved review comments.
>
> src/hotspot/os/linux/os_linux.cpp line 4494:
> 
>> 4492:       LogStream ls(log);
>> 4493: 
>> 4494:       Linux::set_configured_numa_policy(Linux::identify_numa_policy());
> 
> Why this line is removed?
> 
> Linux::_current_numa_policy will not be set properly without this.

It is not removed but moved up to before the if statement (line 4500), because we need to know the policy in `Linux::mem_and_cpu_node_mismatch()`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22395#discussion_r1870899600


More information about the hotspot-runtime-dev mailing list