RFR: 8345514: Should use internal class name when calling ClassLoader.getResourceAsByteArray

Calvin Cheung ccheung at openjdk.org
Thu Dec 5 15:42:49 UTC 2024


On Wed, 4 Dec 2024 18:53:04 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> This patch is for fixing an assert failure in [filemap.cpp](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/cds/filemap.cpp#L2714). It was introduced via JDK-8343427.
>> The bug is that an external class name (e.g. pkg1.Foo) was passed as the argument when calling the java method `ClassLoader.getResourceAsByteArray()` which expects an internal class name (e.g. pkg1/Foo).
>> The test case for JDK-8343427 has been updated to include package names in test classes.
>> 
>> Passed tiers 1 - 5 testing.
>
> LGTM.

Thanks @iklam @matias9927 for the review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22535#issuecomment-2520658978


More information about the hotspot-runtime-dev mailing list