RFR: 8345632: [ASAN] memory leak in get_numbered_property_as_sorted_string function [v2]

[David Holmes]

On Fri, 6 Dec 2024 05:34:54 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into jbs8345632
>>  - 8345632: [ASAN] memory leak in get_numbered_property_as_sorted_string function
>
> src/hotspot/share/classfile/modules.cpp line 732:
> 
>> 730:     os::free((void*)result);
>> 731:     return nullptr;
>> 732:   }
> 
> I think it would be slightly better to avoid the strdup in the empty string case:
> 
> const char* str = st.as_string();
> if (str[0] != 0) {
>   return os::strdup(str);
> } else {
>   return nullptr;
> }

Or slightly cleaner:

return (st.size() > 0)  ? os::strdup(st.as_string()) : nullptr;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22594#discussion_r1872635264