RFR: 8345632: [ASAN] memory leak in get_numbered_property_as_sorted_string function [v3]
Calvin Cheung
ccheung at openjdk.org
Fri Dec 6 17:38:40 UTC 2024
On Fri, 6 Dec 2024 09:04:58 GMT, SendaoYan <syan at openjdk.org> wrote:
>> Hi all,
>> This PR fix memory leak problem in get_numbered_property_as_sorted_string function which introduced by [JDK-8342089](https://bugs.openjdk.org/browse/JDK-8342089) when the function get_numbered_property_as_sorted_string `return nullptr`. Avoid strdup in the empty string case, risk is low.
>>
>> Additional testing:
>>
>> - [x] jtreg tests (include tier1/2/3 etc.) on linux-x64
>> - [x] jtreg tests (include tier1/2/3 etc.) on linux-aarch64
>
> SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>
> - avoid strdup in the empty string case
> - 8345632: [ASAN] memory leak in get_numbered_property_as_sorted_string function
Marked as reviewed by ccheung (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/22594#pullrequestreview-2485499732
More information about the hotspot-runtime-dev
mailing list