RFR: 8345646: aotClassLinking/BulkLoaderTest.java fails if VM options are incompatible

[David Holmes]

On Fri, 6 Dec 2024 06:47:25 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> I added logs that look like this to describe what optimizations are enabled in the CDS archive.
> 
> 
> [0.305s][info][cds] is_dumping_static_archive           = false
> [0.305s][info][cds] is_dumping_dynamic_archive          = true
> [0.305s][info][cds] is_dumping_aot_linked_classes       = false
> [0.305s][info][cds] is_dumping_heap                     = false
> [0.305s][info][cds] is_dumping_invokedynamic            = false
> [0.305s][info][cds] is_dumping_full_module_graph        = false
> [0.305s][info][cds] is_initing_classes_at_dump_time     = false
> 
> 
> If BulkLoaderTest.java finds "is_dumping_aot_linked_classes = false" in the log, that means the current set of VM options are not compatible with `-XX:+AOTClassLinking`. There's no point of continuing with the tests, so we throw a `SkippedException`.

Wouldn't this be better handled by adding support for `@requires vm.cds.AOTClassLinking`?

Adding configuration logging just for a test to process doesn't seem right to me.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22599#pullrequestreview-2487513149