RFR: 8319875: Add macOS implementation for jcmd System.map [v14]
Thomas Stuefe
stuefe at openjdk.org
Mon Dec 9 13:21:46 UTC 2024
On Fri, 6 Dec 2024 22:55:22 GMT, Simon Tooke <stooke at openjdk.org> wrote:
>> This is a port of #16301 to macOS.
>>
>> System.map and System.dump_map are implemented using the macOS API and provide roughly the same information in the same format. Most of the heavy lifting was implemented by @tstuefe in https://github.com/openjdk/jdk/pull/16301 - this PR adds the macOS implementation and enables the common code for macOS 64 bit.
>>
>> The System.map tests are also reworked to be cleaner for the three implementations.
>>
>> [sample output using G1GC](https://github.com/user-attachments/files/17558064/g1_map.txt)
>> [sample output using ZGC](https://github.com/user-attachments/files/17558067/zgc_map.txt)
>
> Simon Tooke has updated the pull request incrementally with one additional commit since the last revision:
>
> add constant
Okay!
Needs a second review. @ashu-mehra, maybe?
src/hotspot/os/bsd/memMapPrinter_macosx.cpp line 49:
> 47: static const int MAX_REGIONS_RETURNED = 1000000;
> 48:
> 49: /*
Can you fix the whitespace error, please? jcheck should pass.
-------------
Marked as reviewed by stuefe (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20953#pullrequestreview-2488780245
PR Review Comment: https://git.openjdk.org/jdk/pull/20953#discussion_r1875967453
More information about the hotspot-runtime-dev
mailing list