RFR: 8337217: Port VirtualMemoryTracker to use VMATree [v9]

Robert Toyonaga duke at openjdk.org
Mon Dec 9 15:47:48 UTC 2024


On Mon, 9 Dec 2024 10:45:34 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> - `VMATree` is used instead of `SortedLinkList` in new class `VirtualMemoryTrackerWithTree`.
>>  -  A wrapper/helper `RegionTree` is made around VMATree to make some calls easier.
>>  -  Both old and new versions exist in the code and can be selected via `MemTracker::set_version()`
>>  - `find_reserved_region()` is used in 4 cases, it will be removed in further PRs.
>>  - All tier1 tests pass except one ~that expects a 50% increase in committed memory but it does not happen~  https://bugs.openjdk.org/browse/JDK-8335167.
>>  - Adding a runtime flag for selecting the old or new version can be added later.
>>  - Some performance tests are added for new version, VMATree and Treap, to show the idea and should be improved later. Based on the results of comparing speed of VMATree and VMT, VMATree shows ~40x faster response time.
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed unused local var.

src/hotspot/share/nmt/regionsTree.hpp line 124:

> 122:     size_t rgn_size = 0;
> 123:     size_t comm_size = 0;
> 124:     size_t base = 0;

I think `base` and `comm_size` are unused.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20425#discussion_r1876223683


More information about the hotspot-runtime-dev mailing list