RFR: 8340401: DcmdMBeanPermissionsTest.java and SystemDumpMapTest.java fail with assert(_stack_base != nullptr) failed: Sanity check [v3]

Thomas Stuefe stuefe at openjdk.org
Tue Dec 10 12:48:46 UTC 2024


On Tue, 3 Dec 2024 20:05:11 GMT, Simon Tooke <stooke at openjdk.org> wrote:

>> This PR addresses JDK-8340401 by adding a test for a thread with no stack currently assigned.
>
> Simon Tooke has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into pr_windows_system_dump_fixes
>  - 8340401: test for thread with uninitialized stack
>  - JDK-8340401: also fix spelling in comment
>  - test for thread with no stack assigned
>  - revert legend fix (will be in a different PR)
>  - update legend text for 'offset'

I still would prefer for vma_touches_thread_stack to be made more robust instead, since it  is used also for iteration of GC threads. Logically, one could argue, it should return false for a `[null, null+0)` stack input range, not crash.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21091#pullrequestreview-2492223662


More information about the hotspot-runtime-dev mailing list