RFR: 8345635: JVMCI compiler should not be disabled by java -Xshare:dump [v2]

[Doug Simon]

On Wed, 11 Dec 2024 21:09:22 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> This PR fixes failures when using  `-XX:+UseJVMCICompiler` with tersts like runtime/cds/appcds/resolvedConstants/AOTLinkedLambdas.java
>> 
>> By default, `java -Xshare:dump` runs the JVM in interpreter-only mode (as if `-Xint` was specified). This behavior is required only when generating deterministic archives during the JDK build. Since those archives are never generated using JVMCI compiler anyway, we don't need to force `-Xint` when `java -Xshare:dump -XX:+UseJVMCICompiler` is used.
>
> Ioi Lam has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Need to check for EnableJVMCI as well
>  - Need to check for EnableJVMCIProduct as well

src/hotspot/share/cds/cdsConfig.cpp line 432:

> 430: 
> 431:   if (is_dumping_static_archive()) {
> 432:     if (!mode_flag_cmd_line JVMCI_ONLY(&& !UseJVMCICompiler && !UseGraalJIT && !EnableJVMCIProduct && !EnableJVMCI)) {

I would suggest expanding the comment to explain why so many JVMCI flags need to be checked here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22687#discussion_r1881032222