RFR: 8345936: Call ClassLoader.getResourceAsByteArray only for multi-release jar [v2]

Calvin Cheung ccheung at openjdk.org
Thu Dec 12 07:30:51 UTC 2024


On Thu, 12 Dec 2024 00:24:19 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @iklam comment
>
> src/hotspot/share/classfile/classLoader.cpp line 859:
> 
>> 857:     bool is_multi_release = ClassLoaderExt::process_jar_manifest(current, entry);
>> 858:     if (is_multi_release) {
>> 859:       entry->set_multi_release_jar();
> 
> Maybe the set_multi_release_jar() call should be moved into process_jar_manifest()? That way, the logic doesn't need to be split in two places.

That's a good idea. I've pushed an update.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22696#discussion_r1881515496


More information about the hotspot-runtime-dev mailing list