RFR: 8340401: DcmdMBeanPermissionsTest.java and SystemDumpMapTest.java fail with assert(_stack_base != nullptr) failed: Sanity check [v2]

[Thomas Stuefe]

On Tue, 10 Dec 2024 19:21:09 GMT, Simon Tooke <stooke at openjdk.org> wrote:

>>> [JDK-8342482](https://bugs.openjdk.org/browse/JDK-8342482) didn't work out.
>> 
>> Thank you for putting the work into this and documenting the result. A negative result is still a result.
>
> @tstuefe I have created a branch with my proposed fix, with a more robust vma_touches_thread_stack() using the new Thread::stack_base_or_null()  method.  It's at [this branch](https://github.com/stooke/jdk/tree/pr_windows_system_dump_fixes2)  I will merge it back here if you approve of the changes.
> 
> Should I un-problemlist the tests in this PR, or should that be a separate PR?

@stooke Yes, I like that better, safe I don't believe we need `Thread::stack_base_or_null` for just one use case. I would do the t->stack_base != NULL test in vma_touches_thread_stack before the range compare (I also keep thinking we should have a generic Range class for this and eventually convert the zillion (start, end) in hotspot ... into uses of that Range class, and such a class would almost certainly barf at negative ranges (start > end)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21091#issuecomment-2538856787