RFR: 8346159: Disable CDS AOTClassLinking tests for JVMCI due to JDK-8345635

Doug Simon dnsimon at openjdk.org
Fri Dec 13 08:59:35 UTC 2024


On Fri, 13 Dec 2024 04:40:16 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Please review this small change to disable some CDS tests that fail due to JDK-8345635.
> 
> Note that I also added `@requires vm.cds.supports.aot.class.linking` to some tests that are using `-XX:+AOTClassLinking` but missed this tag.
> 
> Note: the fix for JDK-8345635 (https://github.com/openjdk/jdk/pull/22687) is causing other issues so it's not ready to be integrated yet.

test/hotspot/jtreg/runtime/cds/appcds/LambdaWithUseImplMethodHandle.java line 31:

> 29:  * @requires vm.cds
> 30:  * @requires vm.cds.supports.aot.class.linking
> 31:  * @requires !vm.jvmci.enabled

Can `@requires` lines have comments? It wouldn't hurt to call out that this is a workaround pending resolution of [JDK-8345969](https://bugs.openjdk.org/browse/JDK-8345969) (or some other issue).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22730#discussion_r1883585128


More information about the hotspot-runtime-dev mailing list