RFR: 8340401: DcmdMBeanPermissionsTest.java and SystemDumpMapTest.java fail with assert(_stack_base != nullptr) failed: Sanity check [v2]

[Simon Tooke]

On Thu, 12 Dec 2024 18:48:59 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> @stooke Yes, I like that better, safe I don't believe we need `Thread::stack_base_or_null` for just one use case. I would do the t->stack_base != NULL test in vma_touches_thread_stack before the range compare (I also keep thinking we should have a generic Range class for this and eventually convert the zillion (start, end) in hotspot ... into uses of that Range class, and such a class would almost certainly barf at negative ranges (start > end)
>
>> @tstuefe we can't call stack_base() because it will throw an assert if it's null. (hence the stack_base_or_null() addition). Would you like me to check stack_size() instead? (my suggestion is to rename stack_base_or_null() to a more generic "has_valid_stack()")
> 
> Oh you are right, I forgot that. No, I think stack_base_or_null is fine in that case.

@tstuefe I have implemented Thread::stack_base_or_null(), and I expect the Gitlab gates to pass.  Two questions:
1) should I check in a SystemDumpMapZGCTest() ?
2) should I remove these tests from the ProblemList files?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21091#issuecomment-2541830960