RFR: 8346231: RISC-V: Fix incorrect assertion in SharedRuntime::generate_handler_blob

Feilong Jiang fjiang at openjdk.org
Sat Dec 14 11:46:18 UTC 2024


On Sat, 14 Dec 2024 08:17:56 GMT, Fei Yang <fyang at openjdk.org> wrote:

> Hi, please review this small change fixing several typos in assertion code.
> 
> I find that the verification of encoding of the poll instruction in this blob is not correct.
> The code loads the instruction and checks for three bit fields, but it uses wrong masks. This
> won't trigger an assertion failure as the masks used are the same as the expected values.
> 
> Testing on linux-riscv64 platform:
> - [ ] hotspot:tier1 (fastdebug)

Nice catch!

-------------

Marked as reviewed by fjiang (Committer).

PR Review: https://git.openjdk.org/jdk/pull/22750#pullrequestreview-2503750625


More information about the hotspot-runtime-dev mailing list