RFR: 8346048: test/lib/containers/docker/DockerRunOptions.java uses addJavaOpts() from ctor

David Holmes dholmes at openjdk.org
Sun Dec 15 21:09:34 UTC 2024


On Sat, 14 Dec 2024 00:21:38 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> Don't methods final, just for using them in ctor.

I would be more inclined to make them final because there is no reason for them to be overridden. Took me a while to realize what was being complained about here: potential invocation of  a subclass implementation of the method before the instance is fully initialized.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22748#issuecomment-2544066333


More information about the hotspot-runtime-dev mailing list