RFR: 8346048: test/lib/containers/docker/DockerRunOptions.java uses addJavaOpts() from ctor [v2]

David Holmes dholmes at openjdk.org
Mon Dec 16 03:51:38 UTC 2024


On Mon, 16 Dec 2024 02:41:27 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Trivial fix to avoid using methods from DockerRunOptions().
>> 
>> Don't methods final, just  for using them in ctor.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   made methods final

Seems fine to me. Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22748#pullrequestreview-2505088672


More information about the hotspot-runtime-dev mailing list