RFR: 8205051: Poor Performance with UseNUMA when cpu and memory nodes are misaligned [v3]

[Swati Sharma]

On Fri, 13 Dec 2024 11:33:56 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Swati Sharma has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8205051: Added an extra method disable_numa to handle individual cases, minor comment change
>
> src/hotspot/os/linux/os_linux.cpp line 4495:
> 
>> 4493:       // Only issue a warning if the user explicitly asked for NUMA support
>> 4494:       log_warning(os)("NUMA support is disabled as libnuma failed to initialize");
>> 4495:     }
> 
> Afaics this block can also use `disable_numa()`.

I agree, addressed.

> src/hotspot/os/linux/os_linux.hpp line 372:
> 
>> 370:   // Check if bound to only one numa node.
>> 371:   // Returns true if bound to a single numa node, otherwise returns false.
>> 372:   static bool is_bound_to_single_mem_node() {
> 
> Suggestion:
> 
>   // Check if memory is bound to only one numa node.
>   // Returns true if memory is bound to a single numa node, otherwise returns false.
>   static bool is_bound_to_single_mem_node() {

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22395#discussion_r1886324249
PR Review Comment: https://git.openjdk.org/jdk/pull/22395#discussion_r1886322279