RFR: 8340631: assert(reserved_rgn->contain_region(base_addr, size)) failed: Reserved CDS region should contain this mapping region

Mon Dec 16 08:59:36 UTC 2024

On Fri, 13 Dec 2024 19:51:47 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> What testing with `UseCompressedClassPointers` set to false, this assert is hit due to memory being released twice during the failure path of CDS archive mapping. This patch makes it so the RW and RO regions are only released once at the end in `MetaspaceShared::release_reserved_spaces()`. Verified with tier 1-4 tests.

Looks good to me.

-------------

Marked as reviewed by jsjolen (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22743#pullrequestreview-2505547113