RFR: 8340631: assert(reserved_rgn->contain_region(base_addr, size)) failed: Reserved CDS region should contain this mapping region [v2]

[Matias Saavedra Silva]

> What testing with `UseCompressedClassPointers` set to false, this assert is hit due to memory being released twice during the failure path of CDS archive mapping. This patch makes it so the RW and RO regions are only released once at the end in `MetaspaceShared::release_reserved_spaces()`. Verified with tier 1-4 tests.

Matias Saavedra Silva has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'master' into cds_mapping_8340631
 - Fixed assert
 - Reverted UseCompressedClassPointers
 - 8340631: assert(reserved_rgn->contain_region(base_addr, size)) failed: Reserved CDS region should contain this mapping region

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22743/files
  - new: https://git.openjdk.org/jdk/pull/22743/files/72f71bd3..4402f98b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22743&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22743&range=00-01

  Stats: 22161 lines in 2895 files changed: 13919 ins; 2624 del; 5618 mod
  Patch: https://git.openjdk.org/jdk/pull/22743.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22743/head:pull/22743

PR: https://git.openjdk.org/jdk/pull/22743