RFR: 8322983: Virtual Threads: exclude 2 tests

Jaikiran Pai jpai at openjdk.org
Tue Dec 17 13:51:37 UTC 2024


On Tue, 17 Dec 2024 07:20:16 GMT, Evgeny Nikitin <enikitin at openjdk.org> wrote:

> Tests
> runtime/classFileParserBug/TestEmptyBootstrapMethodsAttr.java
> runtime/logging/LoaderConstraintsTest.java
> 
> fail with virtual threads. Shouldn't be executed in this mode.
> 
> Testing: tiers 1 through 3 and tier5, all passed.

Marked as reviewed by jpai (Reviewer).

Looking at the linked JBS issue it appears that it was filed almost a year back (for JDK 22 release?). So that would mean that these 2 tests should be failing in virtual thread execution of jtreg currently in mainline. I hadn't seen reports of the failures of these 2 tests before, so I went and looked in our CI runs and indeed these 2 have been failing forever.

Problem listing these 2 for virtual thread execution mode I think is the right thing to do. Please wait for additional reviews from someone else from this area.

At some later date I think these 2 tests (or at least the TestEmptyBootstrapMethodsAttr test) could be updated to make them pass with virtual thread execution mode as well. Looking at that failure and the test itself, it doesn't really have anything to do with virtual threads, so it would be good to address that test failure at some later date.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22782#pullrequestreview-2508938617
PR Comment: https://git.openjdk.org/jdk/pull/22782#issuecomment-2548511485


More information about the hotspot-runtime-dev mailing list