RFR: 8340401: DcmdMBeanPermissionsTest.java and SystemDumpMapTest.java fail with assert(_stack_base != nullptr) failed: Sanity check [v2]

[Simon Tooke]

On Fri, 13 Dec 2024 16:37:52 GMT, Simon Tooke <stooke at openjdk.org> wrote:

>>> @tstuefe we can't call stack_base() because it will throw an assert if it's null. (hence the stack_base_or_null() addition). Would you like me to check stack_size() instead? (my suggestion is to rename stack_base_or_null() to a more generic "has_valid_stack()")
>> 
>> Oh you are right, I forgot that. No, I think stack_base_or_null is fine in that case.
>
> @tstuefe I have implemented Thread::stack_base_or_null(), and I expect the Gitlab gates to pass.  On my VM, I have removed the tests from ProblemList files, and they pass.
> Two questions:
> 1) should I check in a SystemDumpMapZGCTest() ?
> 2) should I remove these tests from the ProblemList files?  (I notice that DcmdMBeanPermissionsTest was actually deleted in [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411))

> @stooke if there is any test in the ProblemList file that lists 8340401, then the PL needs to be updated. Thanks

@dholmes-ora , done.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21091#issuecomment-2548550616