RFR: 8339331: GCC fortify error in vm_version_linux_aarch64.cpp [v3]

SendaoYan syan at openjdk.org
Wed Dec 18 01:41:42 UTC 2024


On Tue, 17 Dec 2024 17:42:11 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - revert to "invalid argument"
>>  - Use PRAGMA_NONNULL_IGNORED to suppress gcc compile warning, and add comments about the gcc bug
>
> src/hotspot/os_cpu/linux_aarch64/vm_version_linux_aarch64.cpp line 192:
> 
>> 190:     // Use pragma to suppress false positive gcc compile warning which maybe be gcc bug
>> 191:     // recorded by https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87489. The false positive warning
>> 192:     // not seen with vanilla gcc release since maybe include some distro-specific gcc patch.
> 
> The wording of the comment is a bit awkward and ungrammatical.  Suggest something like:
> 
> Suppress false positive gcc warning, which may be an example of
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87489
> The warning also hasn't been seen with vanilla gcc release, so may also
> involve some distro-specific gcc patch.

Apologize for my poor English. Thanks your advice.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22655#discussion_r1889475287


More information about the hotspot-runtime-dev mailing list