RFR: 8346605: AIX fastdebug build fails in memoryReserver.cpp after JDK-8345655

[Stefan Karlsson]

On Thu, 19 Dec 2024 14:47:40 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> After "8345655: Move reservation code out of ReservedSpace" the AIX fastdebug build fails with
> 
> 
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-dbg/jdk/src/hotspot/share/memory/memoryReserver.cpp:513:26: error: incomplete type 'os::Aix' named in nested name specifier
>         AIX_ONLY(&& (os::Aix::supports_64K_mmap_pages() || os::vm_page_size() == 4*K))) {
>                      ~~~~^~~~~
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-dbg/jdk/src/hotspot/share/utilities/macros.hpp:399:24: note: expanded from macro 'AIX_ONLY'
> #define AIX_ONLY(code) code
>                        ^~~~
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-dbg/jdk/src/hotspot/share/runtime/os.hpp:1024:9: note: forward declaration of 'os::Aix'
>   class Aix;
> 
> 
> 
> This is seen when configure is called with '--disable-precompiled-headers' .

Approved.

FTR, I think there might be nicer to add an abstraction for this property instead of calling straight into platform-dependent code.

-------------

Marked as reviewed by stefank (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22830#pullrequestreview-2515153146