RFR: 8332506: SIGFPE In ObjectSynchronizer::is_async_deflation_needed()

[Fredrik Bredberg]

On Sun, 22 Dec 2024 20:36:35 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> The transformation using delta is the idiomatic way to convert potentially overflowing (and possibly UB) expressions into a conditional operation that avoids overflow. As Coleen states neither form is generally obvious to all readers.
>
> I'd prefer to see any change to when/why the ceiling is adjusted deferred to the issue that looks at what it should be adjusted to. Nothing about this ceiling is intuitive or obvious to me.

I think it's important that we make sure that the ceiling shouldn't be increased if `monitor_usage` is below the `MonitorUsedDeflationThreshold` in this PR (for the 24 release). But I absolutely agree that we should create a new issue that looks into what it should be adjusted to later.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22815#discussion_r1895089323