RFR: 8346866: [ASAN] memoryReserver.cpp reported applying non-zero offset to non-null pointer produced null pointer [v2]

SendaoYan syan at openjdk.org
Tue Dec 31 09:44:18 UTC 2024


> Hi all,
> This PR add an extra loop condition check `p2u(attach_point) > stepsize` in function `HeapReserver::Instance::try_reserve_range` to make sure the loop will not wrap around, and make UndefinedBehaviorSanitizer silent. The change do not change the original logic, risk is low.
> 
> Additional testing:
> 
> - [ ]  jtreg tests(include tier1/2/3 etc., which include tests added by [PR22712](https://github.com/openjdk/jdk/pull/22712)) on linux-x64 with release build
> - [ ]  jtreg tests(include tier1/2/3 etc., which include tests added by [PR22712](https://github.com/openjdk/jdk/pull/22712)) on linux-x64 with fastdebug build
> - [ ]  jtreg tests(include tier1/2/3 etc., which include tests added by [PR22712](https://github.com/openjdk/jdk/pull/22712)) on linux-aarch64 with release build
> - [ ]  jtreg tests(include tier1/2/3 etc., which include tests added by [PR22712](https://github.com/openjdk/jdk/pull/22712)) on linux-aarch64 with fastdebug build

SendaoYan has updated the pull request incrementally with one additional commit since the last revision:

  Add "attach_point <= stepsize" check at the end of for loop, to make sanitizer silent and avoid warp around.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22897/files
  - new: https://git.openjdk.org/jdk/pull/22897/files/aa5894fd..9b09067c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22897&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22897&range=00-01

  Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/22897.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22897/head:pull/22897

PR: https://git.openjdk.org/jdk/pull/22897


More information about the hotspot-runtime-dev mailing list