RFR: 8313306: More sensible reservation logging [v6]

[David Holmes]

On Wed, 31 Jan 2024 15:45:17 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

>> This PR implements more specialized logs for virtual memory APIs in the “os” namespace. It uses “os” and “map” as log tags using unified JVM logging as introduced in JEP 158 (https://openjdk.org/jeps/158). 
>> 
>> As far as testing is concerned, I have added a regression test to verify the logging is working accordingly.
>
> Sonia Zaldana Calles has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing broken compilation on linux

This is looking a lot cleaner - thanks. Still a couple of small requests.

Note: I have not examined every log statement to see exactly what is being logged - I'm assuming the information is accurate and useful.

src/hotspot/share/runtime/os.hpp line 169:

> 167:         }
> 168: 
> 169:         int saved() {

Please call this `errno()` or `saved_errno()` if the former won't compile.

test/hotspot/jtreg/runtime/os/TestMemoryAllocationLogging.java line 1:

> 1: 

You need a copyright and OpenJDK licence header in this file.

-------------

Changes requested by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17356#pullrequestreview-1855403023
PR Review Comment: https://git.openjdk.org/jdk/pull/17356#discussion_r1473793226
PR Review Comment: https://git.openjdk.org/jdk/pull/17356#discussion_r1473793585