RFR: 8316813: NMT: Using WhiteBox API, virtual memory tracking should also be stressed in JMH tests [v2]

[Afshin Zafari]

On Thu, 1 Feb 2024 11:55:53 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   better names for variables used.
>
> test/micro/org/openjdk/bench/vm/runtime/NMTBenchmark_wb.java line 63:
> 
>> 61:     public int SUB_REGIONS;
>> 62: 
>> 63:     private static final int P = 1024 * 4;
> 
> Better name please!

Done.

> test/micro/org/openjdk/bench/vm/runtime/NMTBenchmark_wb.java line 80:
> 
>> 78:                 t.printStackTrace();
>> 79:                 // Explicit exit to avoid initialization loops.
>> 80:                 System.exit(17);
> 
> What's this exit code?

This part of code is given by JMH developers (@cl4es) and I have no more knowledge than the comments there.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17582#discussion_r1474914811
PR Review Comment: https://git.openjdk.org/jdk/pull/17582#discussion_r1474916153