RFR: 8313306: More sensible reservation logging [v7]

David Holmes dholmes at openjdk.org
Fri Feb 2 05:50:04 UTC 2024


On Thu, 1 Feb 2024 14:18:31 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

>> This PR implements more specialized logs for virtual memory APIs in the “os” namespace. It uses “os” and “map” as log tags using unified JVM logging as introduced in JEP 158 (https://openjdk.org/jeps/158). 
>> 
>> As far as testing is concerned, I have added a regression test to verify the logging is working accordingly.
>
> Sonia Zaldana Calles has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Changing function name and adding copyright header to test

Thanks for the update. One further suggestion for the test, but otherwise nothing further from me.

test/hotspot/jtreg/runtime/os/TestMemoryAllocationLogging.java line 194:

> 192: 
> 193:     private static OutputAnalyzer runTestWithOptions(String[] options) throws IOException {
> 194:         ProcessBuilder pb = ProcessTools.createLimitedTestJavaProcessBuilder(options);

If you are using the "limited" test process then I think the overall test should specify `@requires vm.flagless`.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17356#pullrequestreview-1858369996
PR Review Comment: https://git.openjdk.org/jdk/pull/17356#discussion_r1475570309


More information about the hotspot-runtime-dev mailing list