RFR: JDK-8325158: Revert JDK-8248657 for X86

[David Holmes]

On Fri, 2 Feb 2024 09:42:15 GMT, Nagata-Haruhito <duke at openjdk.org> wrote:

> [JDK-8248657](https://bugs.openjdk.org/browse/JDK-8248657) affects AARCH64 Windows.
> In this fix, always WaitForSingleObject() is called, but it is low performance in multi processes with heavy stress.
> 
> So, I propose threadCritical_windows.cpp move to os_cpu, and revert
> [JDK-8248657](https://bugs.openjdk.org/browse/JDK-8248657) at threadCritical_windows_x86.cpp.

Could you clarify the justification here please. The fix you are reverting went in to JDK 16 and we are now on JDK 23. Is it the case that this startup regression has been detected by some code being tested on JDK 21 that was previously tested on JDK 11, and the performance regression has been tracked, conclusively, to [JDK-8248657](https://bugs.openjdk.org/browse/JDK-8248657)?

Thanks

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17682#issuecomment-1925943450