RFR: 8320002: Remove obsolete CDS check in Reflection::verify_class_access()

[David Holmes]

On Wed, 24 Jan 2024 14:16:40 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Yes, this changes behavior. However, we run a very limited set of Java code during "java -Xshare:dump". Specifically, we never execute any user-supplied code. So even if we perform the real checks, we should always get ACCESS_OK anyway. If we don't, that will be a bug, and we better know about it.

Seems to me like this is/was simply a quick exit path: we know/expect all checks to pass so why bother actually performing them. I'm fine with now actually performing them, in case at some point something is added that could fail, as long as we don't expect anything to actually start failing now.

Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17232#issuecomment-1926047365