RFR: 8325456: Rename nsk_mutex.h
Coleen Phillimore
coleenp at openjdk.org
Thu Feb 8 14:07:58 UTC 2024
On Thu, 8 Feb 2024 05:13:24 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
> Please review this trivial change that renames the file
> test/hotspot/jtreg/vmTestbase/nsk/share/native/nsk_mutex.h to nsk_mutex.hpp.
>
> Testing: mach5 tier1
>
> The usage is odd. The header is only included by the associated .cpp file.
> That .cpp file is included by only one other file, and that file is compiled.
I just had a look at this and the way the file nsk/jvmti/scenarios/events/EM04/em04t001/libem04t001.cpp includes nsk_mutex.cpp is consistent with how it includes other cpp files so not worth changing (ie. deleting this) without more rewriting.
The rename change looks good and is trivial.
-------------
Marked as reviewed by coleenp (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17762#pullrequestreview-1870308513
More information about the hotspot-runtime-dev
mailing list