RFR: 8325456: Rename nsk_mutex.h

Julian Waters jwaters at openjdk.org
Thu Feb 8 15:16:53 UTC 2024


On Thu, 8 Feb 2024 05:13:24 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this trivial change that renames the file
> test/hotspot/jtreg/vmTestbase/nsk/share/native/nsk_mutex.h to nsk_mutex.hpp.
> 
> Testing: mach5 tier1
> 
> The usage is odd.  The header is only included by the associated .cpp file.
> That .cpp file is included by only one other file, and that file is compiled.

Is it worth renaming the included cpp file to hpp as well? Just a small comment

Nevermind, I missed Coleen's comment

-------------

Marked as reviewed by jwaters (Committer).

PR Review: https://git.openjdk.org/jdk/pull/17762#pullrequestreview-1870494010
PR Comment: https://git.openjdk.org/jdk/pull/17762#issuecomment-1934330220


More information about the hotspot-runtime-dev mailing list