RFR: 8324584: Optimize Symbol and char* handling in ClassLoader [v2]

[Matias Saavedra Silva]

On Thu, 8 Feb 2024 06:42:46 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Fixed comment
>>  - Merge branch 'master' into optimize_symbol_char_handling_8324584
>>  - Removed unused argument
>>  - Passed package entry in arguments
>>  - Merge branch 'master' into optimize_symbol_char_handling_8324584
>>  - 8324584: Optimize Symbol and char* handling in ClassLoader
>
> src/hotspot/share/classfile/classLoader.cpp line 1034:
> 
>> 1032: ClassFileStream* ClassLoader::search_module_entries(JavaThread* current,
>> 1033:                                                     const GrowableArray<ModuleClassPathList*>* const module_list,
>> 1034:                                                     Symbol* name,
> 
> AFAICS `name` is never actually used. The class name was only used to get the package entry, which we already have.
> 
> The comment on L1031 also needs updating as no class is involved.

Good catch!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17761#discussion_r1483394438