RFR: 8324584: Optimize Symbol and char* handling in ClassLoader [v2]

Coleen Phillimore coleenp at openjdk.org
Thu Feb 8 23:29:54 UTC 2024


On Thu, 8 Feb 2024 18:11:11 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> The call to `ClassLoader::load_class()` currently takes a Symbol* for the name and later extracts the string only to change it back into a Symbol* inside `ClassLoader::search_module_entries()` while also recalculating the package entry. This patch simply passes the string directly along with the package entry from the caller. Verified with tier1-5 tests.
>
> Matias Saavedra Silva has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Fixed comment
>  - Merge branch 'master' into optimize_symbol_char_handling_8324584
>  - Removed unused argument
>  - Passed package entry in arguments
>  - Merge branch 'master' into optimize_symbol_char_handling_8324584
>  - 8324584: Optimize Symbol and char* handling in ClassLoader

This looks like a good cleanup.  Put noreg-hard on the bug because it's not possible to write a test for this.
Update the copyright years if they haven't been already.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17761#pullrequestreview-1871434055


More information about the hotspot-runtime-dev mailing list