RFR: 8324584: Optimize Symbol and char* handling in ClassLoader [v2]
David Holmes
dholmes at openjdk.org
Thu Feb 8 23:51:04 UTC 2024
On Thu, 8 Feb 2024 23:35:06 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Matias Saavedra Silva has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>>
>> - Fixed comment
>> - Merge branch 'master' into optimize_symbol_char_handling_8324584
>> - Removed unused argument
>> - Passed package entry in arguments
>> - Merge branch 'master' into optimize_symbol_char_handling_8324584
>> - 8324584: Optimize Symbol and char* handling in ClassLoader
>
> src/hotspot/share/classfile/classLoader.hpp line 295:
>
>> 293: static void add_to_exploded_build_list(JavaThread* current, Symbol* module_name);
>> 294:
>> 295: // Attempt load of individual class from either the patched or exploded modules build lists
>
> Can we document what the pkg_entry represents please.
Actually this comment is wrong for this method.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17761#discussion_r1483713950
More information about the hotspot-runtime-dev
mailing list