RFR: 8316813: NMT: Using WhiteBox API, virtual memory tracking should also be stressed in JMH tests [v2]

Johan Sjölen jsjolen at openjdk.org
Mon Feb 12 11:49:55 UTC 2024


On Thu, 1 Feb 2024 18:26:16 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> After WhiteBox (`wb.jar`) is added to the lib-test, it is possible to use it in Java benchmarks. This PR uses WhiteBox to access and call directly NMT API and measure their performance in stressed circumstances.
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
> 
>   better names for variables used.

I'm OK with this, but please fix my review comment.

test/micro/org/openjdk/bench/vm/runtime/NMTBenchmark_wb.java line 145:

> 143: 
> 144:     @Fork(value = 2, jvmArgsPrepend = { WB_JAR_APPEND, WB_UNLOCK_OPTION, WB_API, ADD_EXPORTS, MISC_PACKAGE, "-XX:NativeMemoryTracking=detail"})
> 145:     public static class NMTDetails extends NMTBenchmark_wb { }

Please just `NMTDetail` to mimic the option name.

-------------

Marked as reviewed by jsjolen (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17582#pullrequestreview-1875062367
PR Review Comment: https://git.openjdk.org/jdk/pull/17582#discussion_r1486071983


More information about the hotspot-runtime-dev mailing list