RFR: 8321282: RISC-V: SpinPause() not implemented [v2]
Robbin Ehn
rehn at openjdk.org
Tue Feb 13 13:28:27 UTC 2024
On Tue, 13 Feb 2024 10:51:21 GMT, Fredrik Bredberg <fbredberg at openjdk.org> wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Removed memory clobber
>
> src/hotspot/os_cpu/linux_riscv/os_linux_riscv.cpp line 415:
>
>> 413: // To do: __asm__ volatile("pause " : : : );
>> 414: // We need to compile against march with zihintpause.
>> 415: // Currently we do not.
>
> Just a small improvement suggestion:
>
> // Since we're currently not passing '-march=..._zihintpause' to the compiler,
> // it will not recognize the "pause" instruction, hence the hard-coded instruction.
Fixed!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17820#discussion_r1487843659
More information about the hotspot-runtime-dev
mailing list