RFR: 8313306: More sensible reservation logging [v8]

[Sonia Zaldana Calles]

On Tue, 6 Feb 2024 06:51:58 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Sonia Zaldana Calles has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   adding test flag
>
> src/hotspot/os/aix/os_aix.cpp line 299:
> 
>> 297:     if (::disclaim(p, maxDisclaimSize, DISCLAIM_ZEROMEM) != 0) {
>> 298:       ErrnoPreserver ep;
>> 299:       log_trace(os,map)("disclaim failed: " RANGEFMT " errno=(%s)", RANGEFMTARGS(p, maxDisclaimSize), os::strerror(ep.saved_errno()));
> 
> Lets reduce things a bit.
> 
> Please give ErrnoPreserver a utility function like this:
> 
> os.hpp
> 
> const char* err_text() const;
> 
> 
> that returns os::strerror, then use that one instead in all call sites.

Hi @tstuefe , ErrnoPreserver won't have visibility of os::strerror seeing how it's defined outside of the os class. What would you suggest in that case?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17356#discussion_r1488440121