RFR: 8313306: More sensible reservation logging [v10]

[Thomas Stuefe]

On Wed, 14 Feb 2024 06:40:18 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> src/hotspot/os/aix/os_aix.cpp line 1506:
>> 
>>> 1504:                          RANGEFMTARGS(p, s),
>>> 1505:                          (unsigned long)pagesize);
>>> 1506:       guarantee0(false);
>> 
>> I think the same thing can be done here - move the message into the fatal message.  Why does AIX have this?
>> 
>> #define assert0(b) assert((b), "")
>> #define guarantee0(b) guarantee((b), "")
>> 
>> ??
>
> +1 to fatal().
> 
>>Why does AIX have this?
>>
>>#define assert0(b) assert((b), "")
>>#define guarantee0(b) guarantee((b), "")
>>
>>??
> 
> This is my code I think, from way back when we started the AIX port at SAP. Based on Suns licensed hotspot sources. I really disliked having to state a reason for the assert every time I wrote one, so I saved me work by adding the 0 variants. I kind of came to terms with the reason parameter now.
> 
> Note that was from a time where we could not give back coding upstream, so the AIX port has a number of constructs like this.

But lets leave this for now; lets limit this PR to logging. Code overhaul of the AIX os layer can be done separately.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17356#discussion_r1488982366