RFR: 8324580: SIGFPE on THP initialization on kernels < 4.10 [v4]
Thomas Stuefe
stuefe at openjdk.org
Wed Feb 14 06:55:04 UTC 2024
On Tue, 13 Feb 2024 18:57:19 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:
> > Yeah, I am almost convinced now that modifying `HugePages::thp_pagesize()` would have been better. Maybe with an extra boolean flag that means "We did guess the THP page size".
>
> So far I have just modified logic. One more idea which come to my head was to just make fallback computation as method to HugePages (without logging). And then do something like this:
>
> ```
> _large_page_size = HugePages::thp_pagesize();
> if (_large_page_size == 0) {
> log_info(pagesize) ("Cannot determine THP page size (kernel < 4.10 ?)");
> ...
> _large_page_size = HugePages::thp_pagesize_fallback();
> }
> ```
Yes, we can do that too.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17545#issuecomment-1943178917
More information about the hotspot-runtime-dev
mailing list