RFR: 8324584: Optimize Symbol and char* handling in ClassLoader [v4]

[David Holmes]

On Mon, 12 Feb 2024 17:34:07 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> The call to `ClassLoader::load_class()` currently takes a Symbol* for the name and later extracts the string only to change it back into a Symbol* inside `ClassLoader::search_module_entries()` while also recalculating the package entry. This patch simply passes the string directly along with the package entry from the caller. Verified with tier1-5 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Improved comments

Thanks for the offline discussion @matias9927. I see now that this aligns with the existing `load_shared_class` API (which also doesn't document its arguments and their constraints very well). There is room for some further improvement here but that would be a different RFE.

Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17761#pullrequestreview-1881722839