RFR: 8313306: More sensible reservation logging [v11]

[Thomas Stuefe]

On Wed, 14 Feb 2024 15:31:20 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

>> This PR implements more specialized logs for virtual memory APIs in the “os” namespace. It uses “os” and “map” as log tags using unified JVM logging as introduced in JEP 158 (https://openjdk.org/jeps/158). 
>> 
>> As far as testing is concerned, I have added a regression test to verify the logging is working accordingly.
>
> Sonia Zaldana Calles has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing lingering UL params I missed on fatal call and adding one more fatal call

Hi Sonia, we are getting closer. I don't have to add anything to what Coleen remarked in her last review.

BTW, If you fix a reviewers suggestion, could you please mark that conversation as "Resolved"? Makes it easier to see which ones have been addressed.

src/hotspot/os/bsd/os_bsd.cpp line 1734:

> 1732:                        os::strerror(ep.saved_errno()));
> 1733:     return false;
> 1734:   }

Note: we could probably unify mprotect-with-tracing for all Posix platforms in some followup RFE.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17356#pullrequestreview-1882020723
PR Review Comment: https://git.openjdk.org/jdk/pull/17356#discussion_r1490561751