RFR: 8325983: Build failure after JDK-8324580 [v2]

[Thomas Stuefe]

On Thu, 15 Feb 2024 17:26:06 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

>> I was informed, there is a build failure after [JDK-8324580](https://bugs.openjdk.org/browse/JDK-8324580). This is because there was an intermediate change [JDK-8325306](https://bugs.openjdk.org/browse/JDK-8325306) and while both changes worked independently, merged result does not build.
>> 
>> 
>> jdk/src/hotspot/os/linux/hugepages.cpp:321:9: error: 'supports_static_hugepages' was not declared in this scope; did you mean 'supports_explicit_hugepages'?
>>   321 | if (supports_static_hugepages()) {
>>       | ^~~~~~~~~~~~~~~~~~~~~~~~~
>>       | supports_explicit_hugepages
>
> Zdenek Zambersky has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update comments

The change looks okay. Please make sure to run the jtreg test, just to be sure.

When doing a patch, try merging the master into the patch branch regularly. That can be as simple as a click on the "Sync this branch" button in Github. Then, the GHAs will re-run and in your case we'd have seen the error right away.

That said, you have been unlucky because a concurrent patch that causes build errors usually also causes merge errors, which you see right away.

Please wait for Daniel's okay before pushing.

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17879#pullrequestreview-1883465615