RFR: 8325983: Build failure after JDK-8324580 [v2]

[Daniel D. Daugherty]

On Thu, 15 Feb 2024 17:26:06 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

>> I was informed, there is a build failure after [JDK-8324580](https://bugs.openjdk.org/browse/JDK-8324580). This is because there was an intermediate change [JDK-8325306](https://bugs.openjdk.org/browse/JDK-8325306) and while both changes worked independently, merged result does not build.
>> 
>> 
>> jdk/src/hotspot/os/linux/hugepages.cpp:321:9: error: 'supports_static_hugepages' was not declared in this scope; did you mean 'supports_explicit_hugepages'?
>>   321 | if (supports_static_hugepages()) {
>>       | ^~~~~~~~~~~~~~~~~~~~~~~~~
>>       | supports_explicit_hugepages
>
> Zdenek Zambersky has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update comments

Approved from a build POV. This fix solves the Mach5 Tier1 build problems.

There are 7 windows test tasks remaining in my urgent Tier1 job set. This fix has
nothing to do with windows so I think the build breakage in Mach5 Tier1 is solved
by this fix.

BTW, I checked the last completed Tier8 in Mach5 and I don't see either:

runtime/os/HugePageConfiguration.java or
runtime/os/TestHugePageDecisionsAtVMStartup.java

listed as a test that was run. 

This fix can be integrated from a build POV. I don't know how to resolve @tstuefe testing query.

-------------

Marked as reviewed by dcubed (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17879#pullrequestreview-1883529165
PR Comment: https://git.openjdk.org/jdk/pull/17879#issuecomment-1946869685